[Lldb-commits] [PATCH] D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Nov 4 03:36:46 PST 2020


mgorny added inline comments.


================
Comment at: lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp:250
 
 bool PlatformFreeBSD::CanDebugProcess() {
+  llvm::Triple host_triple{llvm::sys::getProcessTriple()};
----------------
@labath, any clue if I am missing something or is this really sufficient to switch between plugins?


================
Comment at: lldb/test/API/functionalities/avoids-fd-leak/TestFdLeak.py:13
 
-def python_leaky_fd_version(test):
-    import sys
----------------
I've removed this entirely since LLDB does not support Python 2 anymore.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90757/new/

https://reviews.llvm.org/D90757



More information about the lldb-commits mailing list