[Lldb-commits] [lldb] 98257c3 - [lldb] [test] Update XFAILs/skips for FreeBSD

Michał Górny via lldb-commits lldb-commits at lists.llvm.org
Tue Nov 3 13:02:11 PST 2020


Author: Michał Górny
Date: 2020-11-03T22:01:59+01:00
New Revision: 98257c30065a7c85685a60653df7075cf95281dd

URL: https://github.com/llvm/llvm-project/commit/98257c30065a7c85685a60653df7075cf95281dd
DIFF: https://github.com/llvm/llvm-project/commit/98257c30065a7c85685a60653df7075cf95281dd.diff

LOG: [lldb] [test] Update XFAILs/skips for FreeBSD

Update expected failures and test skips based on common results
for the old and new FreeBSD plugins.

Added: 
    

Modified: 
    lldb/test/API/api/multiple-debuggers/TestMultipleDebuggers.py
    lldb/test/API/api/multithreaded/TestMultithreaded.py
    lldb/test/API/commands/expression/multiline-navigation/TestMultilineNavigation.py
    lldb/test/API/commands/log/basic/TestLogging.py
    lldb/test/API/commands/platform/process/list/TestProcessList.py
    lldb/test/API/commands/process/launch/TestProcessLaunch.py
    lldb/test/API/commands/target/create-deps/TestTargetCreateDeps.py
    lldb/test/API/functionalities/breakpoint/breakpoint_callback_command_source/TestBreakpointCallbackCommandSource.py
    lldb/test/API/functionalities/breakpoint/global_constructor/TestBreakpointInGlobalConstructor.py
    lldb/test/API/functionalities/dlopen_other_executable/TestDlopenOtherExecutable.py
    lldb/test/API/functionalities/memory-region/TestMemoryRegion.py
    lldb/test/API/functionalities/thread/exit_during_expression/TestExitDuringExpression.py
    lldb/test/API/functionalities/thread/state_after_expression/TestStateAfterExpression.py
    lldb/test/API/lang/c/conflicting-symbol/TestConflictingSymbol.py
    lldb/test/API/lang/cpp/thread_local/TestThreadLocal.py
    lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_setBreakpoints.py
    lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py
    lldb/test/Shell/Unwind/thread-step-out-ret-addr-check.test

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/api/multiple-debuggers/TestMultipleDebuggers.py b/lldb/test/API/api/multiple-debuggers/TestMultipleDebuggers.py
index d3a69a10baa5..1b120114f710 100644
--- a/lldb/test/API/api/multiple-debuggers/TestMultipleDebuggers.py
+++ b/lldb/test/API/api/multiple-debuggers/TestMultipleDebuggers.py
@@ -19,6 +19,7 @@ class TestMultipleSimultaneousDebuggers(TestBase):
 
     @skipIfNoSBHeaders
     @skipIfWindows
+    @expectedFailureAll(oslist=['freebsd'])
     def test_multiple_debuggers(self):
         env = {self.dylibPath: self.getLLDBLibraryEnvVal()}
 

diff  --git a/lldb/test/API/api/multithreaded/TestMultithreaded.py b/lldb/test/API/api/multithreaded/TestMultithreaded.py
index 60c2c3b372cb..1dc44b9a9448 100644
--- a/lldb/test/API/api/multithreaded/TestMultithreaded.py
+++ b/lldb/test/API/api/multithreaded/TestMultithreaded.py
@@ -31,6 +31,7 @@ def setUp(self):
     @skipIfNoSBHeaders
     # clang-cl does not support throw or catch (llvm.org/pr24538)
     @skipIfWindows
+    @expectedFailureAll(oslist=['freebsd'])
     def test_python_stop_hook(self):
         """Test that you can run a python command in a stop-hook when stdin is File based. """
         self.build_and_test('driver.cpp test_stop-hook.cpp',

diff  --git a/lldb/test/API/commands/expression/multiline-navigation/TestMultilineNavigation.py b/lldb/test/API/commands/expression/multiline-navigation/TestMultilineNavigation.py
index 743e79945364..b932abab82a2 100644
--- a/lldb/test/API/commands/expression/multiline-navigation/TestMultilineNavigation.py
+++ b/lldb/test/API/commands/expression/multiline-navigation/TestMultilineNavigation.py
@@ -18,6 +18,7 @@ class TestCase(PExpectTest):
     # under ASAN on a loaded machine..
     @skipIfAsan
     @skipIfEditlineSupportMissing
+    @expectedFailureAll(oslist=['freebsd'])
     def test_nav_arrow_up(self):
         """Tests that we can navigate back to the previous line with the up arrow"""
         self.launch()
@@ -40,6 +41,7 @@ def test_nav_arrow_up(self):
 
     @skipIfAsan
     @skipIfEditlineSupportMissing
+    @expectedFailureAll(oslist=['freebsd'])
     def test_nav_arrow_down(self):
         """Tests that we can navigate to the next line with the down arrow"""
         self.launch()

diff  --git a/lldb/test/API/commands/log/basic/TestLogging.py b/lldb/test/API/commands/log/basic/TestLogging.py
index 4ba67f8794b6..da1a3e8a50cf 100644
--- a/lldb/test/API/commands/log/basic/TestLogging.py
+++ b/lldb/test/API/commands/log/basic/TestLogging.py
@@ -93,6 +93,8 @@ def test_log_append(self):
 
     # Enable all log options and check that nothing crashes.
     @skipIfWindows
+    # TODO: figure out why it segfaults
+    @skipIfFreeBSD
     def test_all_log_options(self):
         if (os.path.exists(self.log_file)):
             os.remove(self.log_file)

diff  --git a/lldb/test/API/commands/platform/process/list/TestProcessList.py b/lldb/test/API/commands/platform/process/list/TestProcessList.py
index fe2ed74916eb..1bc37b542b19 100644
--- a/lldb/test/API/commands/platform/process/list/TestProcessList.py
+++ b/lldb/test/API/commands/platform/process/list/TestProcessList.py
@@ -19,6 +19,7 @@ class ProcessListTestCase(TestBase):
 
     @skipIfWindows  # https://bugs.llvm.org/show_bug.cgi?id=43702
     @skipIfRemote   # rdar://problem/66542336
+    @expectedFailureAll(oslist=['freebsd'])
     def test_process_list_with_args(self):
         """Test process list show process args"""
         self.build()

diff  --git a/lldb/test/API/commands/process/launch/TestProcessLaunch.py b/lldb/test/API/commands/process/launch/TestProcessLaunch.py
index 9e43c2c3fe28..83bc25d3c9f9 100644
--- a/lldb/test/API/commands/process/launch/TestProcessLaunch.py
+++ b/lldb/test/API/commands/process/launch/TestProcessLaunch.py
@@ -83,7 +83,7 @@ def test_io(self):
     # The process launch flag '-w' for setting the current working directory
     # not working?
     @not_remote_testsuite_ready
-    @expectedFailureAll(oslist=["linux"], bugnumber="llvm.org/pr20265")
+    @expectedFailureAll(oslist=["freebsd", "linux"], bugnumber="llvm.org/pr20265")
     @expectedFailureNetBSD
     @skipIfReproducer
     def test_set_working_dir_nonexisting(self):

diff  --git a/lldb/test/API/commands/target/create-deps/TestTargetCreateDeps.py b/lldb/test/API/commands/target/create-deps/TestTargetCreateDeps.py
index 31be1cc86fa6..0284318a6be1 100644
--- a/lldb/test/API/commands/target/create-deps/TestTargetCreateDeps.py
+++ b/lldb/test/API/commands/target/create-deps/TestTargetCreateDeps.py
@@ -30,7 +30,7 @@ def has_exactly_one_image(self, matching, msg=""):
             "image list", msg, matching=should_match, substrs=['[  1]'])
 
 
-    @expectedFailureAll(oslist=["linux"],
+    @expectedFailureAll(oslist=["freebsd", "linux"],
         triple=no_match(".*-android"))
         #linux does not support loading dependent files, but android does
     @expectedFailureNetBSD
@@ -40,7 +40,7 @@ def test_dependents_implicit_default_exe(self):
         self.runCmd("target create  " + exe, CURRENT_EXECUTABLE_SET)
         self.has_exactly_one_image(False)
 
-    @expectedFailureAll(oslist=["linux"],
+    @expectedFailureAll(oslist=["freebsd", "linux"],
         triple=no_match(".*-android"))
         #linux does not support loading dependent files, but android does
     @expectedFailureNetBSD
@@ -56,7 +56,7 @@ def test_dependents_explicit_true_exe(self):
         self.runCmd("target create -dtrue " + exe, CURRENT_EXECUTABLE_SET)
         self.has_exactly_one_image(True)
 
-    @expectedFailureAll(oslist=["linux"],
+    @expectedFailureAll(oslist=["freebsd", "linux"],
         triple=no_match(".*-android"))
         #linux does not support loading dependent files, but android does
     @expectedFailureNetBSD
@@ -94,7 +94,7 @@ def test_dependents_explicit_true_lib(self):
         self.runCmd("target create -dtrue " + lib, CURRENT_EXECUTABLE_SET)
         self.has_exactly_one_image(True)
 
-    @expectedFailureAll(oslist=["linux"],
+    @expectedFailureAll(oslist=["freebsd", "linux"],
         triple=no_match(".*-android"))
         #linux does not support loading dependent files, but android does
     @expectedFailureNetBSD

diff  --git a/lldb/test/API/functionalities/breakpoint/breakpoint_callback_command_source/TestBreakpointCallbackCommandSource.py b/lldb/test/API/functionalities/breakpoint/breakpoint_callback_command_source/TestBreakpointCallbackCommandSource.py
index fb7ae1dc9fa6..8b20bed0b097 100644
--- a/lldb/test/API/functionalities/breakpoint/breakpoint_callback_command_source/TestBreakpointCallbackCommandSource.py
+++ b/lldb/test/API/functionalities/breakpoint/breakpoint_callback_command_source/TestBreakpointCallbackCommandSource.py
@@ -19,6 +19,8 @@ class BreakpointCallbackCommandSource(PExpectTest):
     # under ASAN on a loaded machine..
     @skipIfAsan
     @skipIfEditlineSupportMissing
+    # times out
+    @skipIfFreeBSD
     def test_breakpoint_callback_command_source(self):
         self.build()
         exe = self.getBuildArtifact("a.out")

diff  --git a/lldb/test/API/functionalities/breakpoint/global_constructor/TestBreakpointInGlobalConstructor.py b/lldb/test/API/functionalities/breakpoint/global_constructor/TestBreakpointInGlobalConstructor.py
index 4439607d91cf..372a9151e014 100644
--- a/lldb/test/API/functionalities/breakpoint/global_constructor/TestBreakpointInGlobalConstructor.py
+++ b/lldb/test/API/functionalities/breakpoint/global_constructor/TestBreakpointInGlobalConstructor.py
@@ -15,6 +15,7 @@ class TestBreakpointInGlobalConstructors(TestBase):
     mydir = TestBase.compute_mydir(__file__)
     NO_DEBUG_INFO_TESTCASE = True
 
+    @expectedFailureAll(oslist=["freebsd"])
     @expectedFailureNetBSD
     def test(self):
         self.build()

diff  --git a/lldb/test/API/functionalities/dlopen_other_executable/TestDlopenOtherExecutable.py b/lldb/test/API/functionalities/dlopen_other_executable/TestDlopenOtherExecutable.py
index 2ccfaeaea41a..2563f3a24a96 100644
--- a/lldb/test/API/functionalities/dlopen_other_executable/TestDlopenOtherExecutable.py
+++ b/lldb/test/API/functionalities/dlopen_other_executable/TestDlopenOtherExecutable.py
@@ -12,6 +12,7 @@ class TestCase(TestBase):
     # glibc's dlopen doesn't support opening executables.
     # https://sourceware.org/bugzilla/show_bug.cgi?id=11754
     @skipIfLinux
+    @expectedFailureAll(oslist=["freebsd"])
     @no_debug_info_test
     def test(self):
         self.build()

diff  --git a/lldb/test/API/functionalities/memory-region/TestMemoryRegion.py b/lldb/test/API/functionalities/memory-region/TestMemoryRegion.py
index 61e64d44e794..36984b3d1666 100644
--- a/lldb/test/API/functionalities/memory-region/TestMemoryRegion.py
+++ b/lldb/test/API/functionalities/memory-region/TestMemoryRegion.py
@@ -23,6 +23,7 @@ def setUp(self):
             'main.cpp',
             '// Run here before printing memory regions')
 
+    @expectedFailureAll(oslist=["freebsd"])
     def test(self):
         self.build()
 

diff  --git a/lldb/test/API/functionalities/thread/exit_during_expression/TestExitDuringExpression.py b/lldb/test/API/functionalities/thread/exit_during_expression/TestExitDuringExpression.py
index 260fe596a39f..84c3094e39c2 100644
--- a/lldb/test/API/functionalities/thread/exit_during_expression/TestExitDuringExpression.py
+++ b/lldb/test/API/functionalities/thread/exit_during_expression/TestExitDuringExpression.py
@@ -15,11 +15,13 @@ class TestExitDuringExpression(TestBase):
     NO_DEBUG_INFO_TESTCASE = True
 
     @skipIfWindows
+    @expectedFailureAll(oslist=["freebsd"])
     def test_exit_before_one_thread_unwind(self):
         """Test the case where we exit within the one thread timeout"""
         self.exiting_expression_test(True, True)
 
     @skipIfWindows
+    @expectedFailureAll(oslist=["freebsd"])
     def test_exit_before_one_thread_no_unwind(self):
         """Test the case where we exit within the one thread timeout"""
         self.exiting_expression_test(True, False)

diff  --git a/lldb/test/API/functionalities/thread/state_after_expression/TestStateAfterExpression.py b/lldb/test/API/functionalities/thread/state_after_expression/TestStateAfterExpression.py
index b108d53c9654..ef619e887d6c 100644
--- a/lldb/test/API/functionalities/thread/state_after_expression/TestStateAfterExpression.py
+++ b/lldb/test/API/functionalities/thread/state_after_expression/TestStateAfterExpression.py
@@ -15,6 +15,7 @@ class TestStopReasonAfterExpression(TestBase):
     mydir = TestBase.compute_mydir(__file__)
 
     @skipIfWindows
+    @expectedFailureAll(oslist=["freebsd"])
     def test_thread_state_after_expr(self):
         self.build()
         self.main_source_file = lldb.SBFileSpec("main.cpp")

diff  --git a/lldb/test/API/lang/c/conflicting-symbol/TestConflictingSymbol.py b/lldb/test/API/lang/c/conflicting-symbol/TestConflictingSymbol.py
index 9d088e308edf..13eae55bfa2c 100644
--- a/lldb/test/API/lang/c/conflicting-symbol/TestConflictingSymbol.py
+++ b/lldb/test/API/lang/c/conflicting-symbol/TestConflictingSymbol.py
@@ -18,7 +18,7 @@ def setUp(self):
         lldbutil.mkdir_p(self.getBuildArtifact("One"))
         lldbutil.mkdir_p(self.getBuildArtifact("Two"))
 
-    @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24489")
+    @expectedFailureAll(oslist=["freebsd", "windows"], bugnumber="llvm.org/pr24489")
     @expectedFailureNetBSD
     def test_conflicting_symbols(self):
         self.build()

diff  --git a/lldb/test/API/lang/cpp/thread_local/TestThreadLocal.py b/lldb/test/API/lang/cpp/thread_local/TestThreadLocal.py
index b92ec90ff77d..765bf3b2b492 100644
--- a/lldb/test/API/lang/cpp/thread_local/TestThreadLocal.py
+++ b/lldb/test/API/lang/cpp/thread_local/TestThreadLocal.py
@@ -11,7 +11,7 @@ class PlatformProcessCrashInfoTestCase(TestBase):
 
     mydir = TestBase.compute_mydir(__file__)
 
-    @expectedFailureAll(oslist=["windows", "linux", "netbsd"])
+    @expectedFailureAll(oslist=["windows", "linux", "freebsd", "netbsd"])
     def test_thread_local(self):
         # Set a breakpoint on the first instruction of the main function,
         # before the TLS initialization has run.

diff  --git a/lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_setBreakpoints.py b/lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_setBreakpoints.py
index 23f4ad216ea2..aa3d5f1ab147 100644
--- a/lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_setBreakpoints.py
+++ b/lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_setBreakpoints.py
@@ -25,6 +25,7 @@ def setUp(self):
 
     @skipIfWindows
     @skipIfRemote
+    @expectedFailureAll(oslist=["freebsd"])
     def test_source_map(self):
         self.build_and_create_debug_adaptor()
 
@@ -89,6 +90,7 @@ def test_source_map(self):
 
     @skipIfWindows
     @skipIfRemote
+    @expectedFailureAll(oslist=["freebsd"])
     def test_set_and_clear(self):
         '''Tests setting and clearing source file and line breakpoints.
            This packet is a bit tricky on the debug adaptor side since there
@@ -221,6 +223,7 @@ def test_set_and_clear(self):
 
     @skipIfWindows
     @skipIfRemote
+    @expectedFailureAll(oslist=["freebsd"])
     def test_clear_breakpoints_unset_breakpoints(self):
         '''Test clearing breakpoints like test_set_and_clear, but clear
            breakpoints by omitting the breakpoints array instead of sending an
@@ -263,6 +266,7 @@ def test_clear_breakpoints_unset_breakpoints(self):
 
     @skipIfWindows
     @skipIfRemote
+    @expectedFailureAll(oslist=["freebsd"])
     def test_functionality(self):
         '''Tests hitting breakpoints and the functionality of a single
            breakpoint, like 'conditions' and 'hitCondition' settings.'''

diff  --git a/lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py b/lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py
index b63eb6e7201c..c3b7f16ab2db 100644
--- a/lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py
+++ b/lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py
@@ -182,6 +182,7 @@ def test_disableSTDIO(self):
     @skipIfWindows
     @skipIfLinux # shell argument expansion doesn't seem to work on Linux
     @expectedFailureNetBSD
+    @expectedFailureAll(oslist=["freebsd"])
     @skipIfRemote
     def test_shellExpandArguments_enabled(self):
         '''

diff  --git a/lldb/test/Shell/Unwind/thread-step-out-ret-addr-check.test b/lldb/test/Shell/Unwind/thread-step-out-ret-addr-check.test
index 682b0e5332b1..113922ef53b7 100644
--- a/lldb/test/Shell/Unwind/thread-step-out-ret-addr-check.test
+++ b/lldb/test/Shell/Unwind/thread-step-out-ret-addr-check.test
@@ -3,6 +3,7 @@
 
 # REQUIRES: target-x86_64
 # UNSUPPORTED: system-windows
+# XFAIL: system-freebsd
 
 # RUN: %clang_host %p/Inputs/call-asm.c -x assembler-with-cpp %p/Inputs/thread-step-out-ret-addr-check.s -o %t
 # RUN: not %lldb %t -s %s -b 2>&1 | FileCheck %s


        


More information about the lldb-commits mailing list