[Lldb-commits] [PATCH] D88581: [lldb] Symlink the Clang resource directory to the LLDB build directory in standalone builds

[Marko Novakovic via Phabricator via lldb-commits]

mnovakovic added inline comments.


================
Comment at: lldb/source/API/CMakeLists.txt:210
+  if(NOT LLDB_BUILD_FRAMEWORK)
+    set(LLDB_CLANG_RESOURCE_DIR_PARENT "$<TARGET_PROPERTY:liblldb,LIBRARY_OUTPUT_DIRECTORY>/clang")
+    file(MAKE_DIRECTORY "${LLDB_CLANG_RESOURCE_DIR_PARENT}")
----------------
JDevlieghere wrote:
> Can you check that this works in a non-framework Xcode build (or any other multi-config generator). I think the generator expressions are resolved too late.
Good catch and this doesn't work in a non-Framework context. I am building standalone LLDB and it fails on the next line: `file(MAKE_DIRECTORY "${LLDB_CLANG_RESOURCE_DIR_PARENT}")`

That line is not even needed because line 214 builds the directory already, the fix for this could be to just remove like 211 and only build directory in the post_build phase.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88581/new/

https://reviews.llvm.org/D88581