[Lldb-commits] [PATCH] D90490: [intel-pt][trace] Implement a "get supported trace type" packet

[walter erquinigo via Phabricator via lldb-commits]

wallace updated this revision to Diff 302402.
wallace edited the summary of this revision.
wallace added a comment.

Thanks for the feedback! Some changes:

- I'm no longer showing the AAAAA in the documentation, as @labath pointed out that I was not using it, and, in fact, there's no need to use it.
- I'm now using a json array to represent the return value of the packet. It's going to be a 0 or 1 element array for, probably, many years, but it makes the packet more robust and can use the j prefix sensically.
- I improved the documentation, addressing @DavidSpickett questions. In short, a TraceType corresponds to a high-level Trace plugin that can provide LLDB with a list of instructions executed by a given program.
- I renamed eTraceTypeProcessorTrace to eTraceTypeIntelProcessorTrace (notice the Intel word) to disambiguate.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90490/new/

https://reviews.llvm.org/D90490

Files:
  lldb/docs/lldb-gdb-remote.txt
  lldb/include/lldb/Host/common/NativeProcessProtocol.h
  lldb/include/lldb/Target/Process.h
  lldb/include/lldb/Utility/StringExtractorGDBRemote.h
  lldb/include/lldb/lldb-enumerations.h
  lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp
  lldb/source/Plugins/Process/Linux/NativeProcessLinux.h
  lldb/source/Plugins/Process/Linux/ProcessorTrace.cpp
  lldb/source/Plugins/Process/Linux/ProcessorTrace.h
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.h
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
  lldb/source/Utility/StringExtractorGDBRemote.cpp
  lldb/tools/intel-features/intel-pt/Decoder.cpp
  lldb/tools/intel-features/intel-pt/PTDecoder.h
  lldb/tools/intel-features/intel-pt/README_TOOL.txt
  lldb/tools/intel-features/intel-pt/cli-wrapper-pt.cpp
  lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90490.302402.patch
Type: text/x-patch
Size: 24093 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20201102/040c0dd7/attachment-0001.bin>