[Lldb-commits] [PATCH] D90490: [intel-pt][trace] Implement a "get supported trace type" packet

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added inline comments.


================
Comment at: lldb/docs/lldb-gdb-remote.txt:245
+//
+//  See lldb-enumerations for the list of available TraceType's.
+//
----------------
Saying `lldb-enumerations.h` might save someone some grepping time, also saying that it should be in decimal.

Can you clarify what TraceType means? Is it:
The way the trace is generated/stored, like on chip vs off chip
The thing you're tracging, e.g. instructions or power usage
Specific trace versions e.g intel pt, arm coresight (pretty sure it's not this one)

If there's the possibility of one system having multiple types then the packet should at least have the format to hold them, even though we only read the first one.

Which your code already does since:
1,2;
Would stop parsing at the ',' anyway, but worth noting if it's relevant.


================
Comment at: lldb/docs/lldb-gdb-remote.txt:254
+send packet: jTraceSupportedType
+read packet: <trace type>/E<error code>;AAAAAAAAA
+
----------------
What is the AAAAA for?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90490/new/

https://reviews.llvm.org/D90490