[Lldb-commits] [PATCH] D87172: Check if debug line sequences are starting after the first code segment

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:503-505
+  if (section_list) {
+    InitializeFirstCodeAddress(*section_list);
+  }
----------------
aadsm wrote:
> labath wrote:
> > clayborg wrote:
> > > remove braces
> > or even fold the declaration into the if condition.
> folding was not possible as clang-formatter didn't allow it.
> 
I meant:
```
if(const SectionList *section_list = m_objfile_sp->GetModule()->GetSectionList())
  InitializeFirstCodeAddress(*section_list);
```

We have plently of code like that, so clang-format should not have a problem.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87172/new/

https://reviews.llvm.org/D87172