[Lldb-commits] [PATCH] D87173: Ignores functions that have a range starting outside of a code section

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added inline comments.


================
Comment at: lldb/test/Shell/SymbolFile/DWARF/function-entries-invalid-addresses.yaml:5-12
+image lookup -F main
+# RUN: %lldb %t/test.obj -b -o "settings set interpreter.stop-command-source-on-error false" -s %t/check-main.lldb-commands | FileCheck --check-prefix MAIN %s
+# MAIN: 1 match found {{.*}}
+
+#--- check-foo.lldb-commands
+image lookup -F foo
+# RUN: %lldb %t/test.obj -b -o "settings set interpreter.stop-command-source-on-error false" -s %t/check-foo.lldb-commands | FileCheck --check-prefix FOO %s
----------------
Now that the command interpreter doesn't stop when it encounters errors, you can merge these two checks into one. You can check for the commands in order to "divide" the output:
```
# CHECK-LABEL: image lookup -F main
# CHECK: 1 match found
# CHECK-LABEL: image lookup -F foo
# CHECK-NOT: 1 match found
```
(CHECK-LABEL behaves like a regular CHECK, only it also gives a hint to FileCheck that the checks are independent  -- so it will e.g. still try to match the second one if the first one fails).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87173/new/

https://reviews.llvm.org/D87173