[Lldb-commits] [PATCH] D89157: [lldb] Report old modules from ModuleList::ReplaceEquivalent

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Oct 29 11:10:50 PDT 2020


jingham added a comment.

All the parts of D89156 <https://reviews.llvm.org/D89156> that are just being consistent about always passing old_modules as a vector seem okay.  But then you get to a point where you shouldn't really have multiple modules replacing a single one so you aren't really sure what to do about it.  That part makes me a little uneasy.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89157/new/

https://reviews.llvm.org/D89157



More information about the lldb-commits mailing list