[Lldb-commits] [PATCH] D82864: [lldb] Replace host-typed Scalar accessors with [SZ]ExtOrTruncInt

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil added inline comments.


================
Comment at: lldb/source/Core/ValueObject.cpp:467
   bool ret;
-  ret = scalar_value.ULongLong(1) != 0;
+  ret = scalar_value != 0;
   error.Clear();
----------------
mib wrote:
> Any reason why this is not inlined in the definition ?
IMO this patch does only the renaming, it should not do unrelated code cleanups.
For example by `s/ZExtOrTruncInt/ULongLong/ s/SExtOrTruncInt/SLongLong/` + clang-format one should get zero-sized patch to verify there are no unintended changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82864/new/

https://reviews.llvm.org/D82864