[Lldb-commits] [PATCH] D89157: [lldb] Report old modules from ModuleList::ReplaceEquivalent

Wed Oct 28 15:26:48 PDT 2020

jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.

I can't see anything wrong with this, it seems to follow the practice of other parts of GetSharedModule.  I'm still not quite certain why I've never seen an instance where the absence of your fix has caused problems, and it isn't clear from the patch why that is.  If there something special about handling breakpad files that moves you out of the normal code path for replacing overridden modules?  So I still have a lurking feeling I'm missing something?

OTOH, seems like any time you find that one module is a newer version of one you held onto you should mention it, so this seems okay.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89157/new/

https://reviews.llvm.org/D89157