[Lldb-commits] [PATCH] D90318: Return actual type from SBType::GetArrayElementType

Jaroslav Sevcik via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 28 11:46:30 PDT 2020


jarin accepted this revision.
jarin added a comment.
This revision is now accepted and ready to land.

The code change looks good to me and it is in line with the change that Raphael and Greg wanted in https://reviews.llvm.org/D72133. As far as I remember, https://reviews.llvm.org/D72133 did not change the previous behavior because I felt that changing API semantics was out of scope of what I wanted to do with the formatters.

Someone else should look at the test. The addition seems to be a bit ad-hoc, but overall reasonable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90318/new/

https://reviews.llvm.org/D90318



More information about the lldb-commits mailing list