[Lldb-commits] [PATCH] D89334: [lldb] Support Python imports relative the to the current file being sourced

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Let's see how this goes.



================
Comment at: lldb/source/Commands/Options.td:709
+    Group<1>, Desc<"Resolve relative paths relative to the location of the "
+    "current command file being sourced. This argument is ignored when not "
+    "coming form a command file.">;
----------------
It might be better to make this an error


================
Comment at: lldb/test/Shell/ScriptInterpreter/Python/command_relative_import.test:4-9
+# RUN: cp %S/Inputs/magritte.py %t/foo
+# RUN: cp %S/Inputs/magritte.in %t/foo
+# RUN: cp %S/Inputs/zip.py %t/foo
+# RUN: cp %S/Inputs/zip.in %t/foo
+# RUN: cp %S/Inputs/hello.py %t/foo/bar/baz
+# RUN: cp %S/Inputs/hello.in %t/foo/bar
----------------
consider using the (new) split-file utility -- It can split single file into multiple chunks and place them in the appropriate folders.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89334/new/

https://reviews.llvm.org/D89334