[Lldb-commits] [PATCH] D90102: [lldb] [Process/FreeBSDRemote] Enable watchpoint support

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 27 02:30:22 PDT 2020


labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeThreadFreeBSD.cpp:192-193
+    return Status("not implemented");
+  if (m_state == eStateLaunching)
+    return Status();
+  Status error = RemoveWatchpoint(addr);
----------------
Are you actually using this state for anything? Should this be an assert? Maybe `assert(m_state == eStateStopped)` even ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90102/new/

https://reviews.llvm.org/D90102



More information about the lldb-commits mailing list