[Lldb-commits] [PATCH] D89812: [lldb][PDB] Add ObjectFile PDB plugin

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: lldb/source/Plugins/ObjectFile/PDB/CMakeLists.txt:6
+    lldbCore
+    lldbHost
+    lldbSymbol
----------------
I don't see this using any Host functionality.


================
Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:855
   m_sections_up = std::make_unique<SectionList>();
-
   ModuleSP module_sp(GetModule());
----------------
this too


================
Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:145
     return nullptr;
-
   return objfile_up.release();
----------------
labath wrote:
> revert spurious changes.
do revert this before committing.


================
Comment at: lldb/test/Shell/ObjectFile/PDB/object.test:1
+# RUN: llvm-pdbutil yaml2pdb %p/Inputs/pdb.yaml -pdb=%t.pdb
+# RUN: lldb-test object-file %t.pdb | FileCheck %s
----------------
Consider "inlining" the yaml input into this file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89812/new/

https://reviews.llvm.org/D89812