[Lldb-commits] [PATCH] D90114: [lldb] [test/Register] Use initial state for write tests

[Michał Górny via Phabricator via lldb-commits]

mgorny created this revision.
mgorny added reviewers: labath, krytarowski, emaste.
mgorny requested review of this revision.

Reset registers to their 'initial' state instead of a semi-random
pattern in write tests.  While the latter might have been helpful
while debugging failures (i.e. to distinguish unmodified registers
from mistakenly written zeroes), the former makes it possible to test
whether xstate_bv field is written correctly when using XSAVE.

With this change, the four relevant tests start failing on NetBSD
without D90105 <https://reviews.llvm.org/D90105>.


https://reviews.llvm.org/D90114

Files:
  lldb/test/Shell/Register/Inputs/x86-64-write.cpp
  lldb/test/Shell/Register/Inputs/x86-mm-xmm-write.cpp
  lldb/test/Shell/Register/Inputs/x86-ymm-write.cpp
  lldb/test/Shell/Register/Inputs/x86-zmm-write.cpp


Index: lldb/test/Shell/Register/Inputs/x86-zmm-write.cpp
===================================================================
--- lldb/test/Shell/Register/Inputs/x86-zmm-write.cpp
+++ lldb/test/Shell/Register/Inputs/x86-zmm-write.cpp
@@ -9,10 +9,7 @@
 
 int main() {
   constexpr zmm_t zmm_fill = {
-    .as_uint64 = { 0x0F0F0F0F0F0F0F0F, 0x0F0F0F0F0F0F0F0F,
-                   0x0F0F0F0F0F0F0F0F, 0x0F0F0F0F0F0F0F0F,
-                   0x0F0F0F0F0F0F0F0F, 0x0F0F0F0F0F0F0F0F,
-                   0x0F0F0F0F0F0F0F0F, 0x0F0F0F0F0F0F0F0F }
+    .as_uint64 = { 0, 0, 0, 0, 0, 0, 0, 0 }
   };
 
   zmm_t zmm[32];
Index: lldb/test/Shell/Register/Inputs/x86-ymm-write.cpp
===================================================================
--- lldb/test/Shell/Register/Inputs/x86-ymm-write.cpp
+++ lldb/test/Shell/Register/Inputs/x86-ymm-write.cpp
@@ -9,8 +9,7 @@
 
 int main() {
   constexpr ymm_t ymm_fill = {
-    .as_uint64 = { 0x0F0F0F0F0F0F0F0F, 0x0F0F0F0F0F0F0F0F,
-                   0x0F0F0F0F0F0F0F0F, 0x0F0F0F0F0F0F0F0F }
+    .as_uint64 = { 0, 0, 0, 0 }
   };
 
   ymm_t ymm[16];
Index: lldb/test/Shell/Register/Inputs/x86-mm-xmm-write.cpp
===================================================================
--- lldb/test/Shell/Register/Inputs/x86-mm-xmm-write.cpp
+++ lldb/test/Shell/Register/Inputs/x86-mm-xmm-write.cpp
@@ -9,7 +9,7 @@
 
 int main() {
   constexpr xmm_t xmm_fill = {
-    .as_uint64 = { 0x0F0F0F0F0F0F0F0F, 0x0F0F0F0F0F0F0F0F }
+    .as_uint64 = { 0, 0 }
   };
 
   uint64_t mm[8];
Index: lldb/test/Shell/Register/Inputs/x86-64-write.cpp
===================================================================
--- lldb/test/Shell/Register/Inputs/x86-64-write.cpp
+++ lldb/test/Shell/Register/Inputs/x86-64-write.cpp
@@ -9,7 +9,7 @@
 
 int main() {
   constexpr xmm_t xmm_fill = {
-    .as_uint64 = { 0x0F0F0F0F0F0F0F0F, 0x0F0F0F0F0F0F0F0F }
+    .as_uint64 = { 0, 0 }
   };
 
   uint64_t r64[8];


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90114.300527.patch
Type: text/x-patch
Size: 1918 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20201025/8245dfdd/attachment.bin>