[Lldb-commits] [PATCH] D89600: [lldb] Move copying of reproducer out of process

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.


================
Comment at: lldb/source/Utility/Reproducer.cpp:389
+
+  if (auto files = llvm::MemoryBuffer::getFile(files_path)) {
+    SmallVector<StringRef, 20> paths;
----------------
labath wrote:
> Is this deliberately ignoring a possible error?
It was because we were only opening/creating the file when adding to it but that's no longer the case. 


================
Comment at: lldb/test/Shell/Reproducer/TestFinalize.test:5-6
+# RUN: touch %t.repro/index.yaml
+# RUN: printf "%t.known.file" > %t.repro/files.txt
+# RUN: printf "%t.known.dir" > %t.repro/dirs.txt
+
----------------
labath wrote:
> s/printf/echo. printf is not needed here, and I'm not sure it would work on windows.
It was to avoid the newline, but I can pass `-n`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89600/new/

https://reviews.llvm.org/D89600