[Lldb-commits] [PATCH] D90034: [lldb] [Process/NetBSD] Use XStateRegSet for all FPU registers

Michał Górny via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 23 05:40:56 PDT 2020


mgorny created this revision.
mgorny added reviewers: krytarowski, labath.
Herald added a subscriber: pengfei.
mgorny requested review of this revision.

Unify the x86 regset API to use XStateRegSet for all FPU registers,
therefore eliminating the legacy API based on FPRegSet.  This makes
the code a little bit simpler but most notably, it provides future
compatibility for register caching.

Since the NetBSD kernel takes care of providing compatibility with
pre-XSAVE processors, PT_{G,S}ETXSTATE can be used on systems supporting
only FXSAVE or even plain FSAVE (and unlike PT_{G,S}ETXMMREGS, it
clearly indicates that XMM registers are not supported).


https://reviews.llvm.org/D90034

Files:
  lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.cpp
  lldb/source/Plugins/Process/NetBSD/NativeRegisterContextNetBSD_x86_64.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90034.300254.patch
Type: text/x-patch
Size: 16803 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20201023/b86e7118/attachment.bin>


More information about the lldb-commits mailing list