[Lldb-commits] [PATCH] D89925: [lldb] Fix a regression introduced by D75730

Thu Oct 22 02:47:10 PDT 2020

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

If needed, we can add some `#ifdef`s to produce suitable instructions on other architectures too.

================
Comment at: lldb/source/Core/Disassembler.cpp:544
                                const char *plugin_name, const char *flavor,
                                const ExecutionContext &exe_ctx,
                                uint32_t num_instructions,
----------------
Maybe change this to take a `StackFrame&` argument? The only caller StackFrame::Disassemble, so the frame argument is always valid (and a lot of this defensive code is not needed).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89925/new/

https://reviews.llvm.org/D89925