[Lldb-commits] [PATCH] D89925: [lldb] Fix a regression introduced by D75730

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda added a comment.

So in this patch you're setting the limit to be the size of the range (for someone who did 'disass -s 0x100 -e 0x200' they would be requesting 100 instructions) but the disassembly returned would be limited by the byte range requested, so this works OK.  The asm(nop) is to guarantee that sum() has at least one instruction?  There's no documentation for the Disassembler ctors where we might mention that the use case is either (1) an AddressRange, or (2) a start address and instruction count, but maybe there should be?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89925/new/

https://reviews.llvm.org/D89925