[Lldb-commits] [PATCH] D89874: [lldb] Unify x86 watchpoint implementation on Linux and NetBSD (and future FreeBSD plugin) [WIP]

Kamil Rytarowski via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 21 08:56:42 PDT 2020


krytarowski added inline comments.


================
Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:580
 
-  if (IsGPR(reg_index))
+  if (IsGPROrDR(reg_index))
     return WriteRegisterRaw(reg_index, reg_value);
----------------
Can we have `IsGPR(reg_index) || IsDR(reg_index)`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89874/new/

https://reviews.llvm.org/D89874



More information about the lldb-commits mailing list