[Lldb-commits] [PATCH] D89874: [lldb] Unify x86 watchpoint implementation on Linux and NetBSD (and future FreeBSD plugin) [WIP]

Wed Oct 21 05:57:04 PDT 2020

mgorny added inline comments.

================
Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.h:110

-  bool IsGPR(uint32_t reg_index) const;
+  bool IsGPROrDR(uint32_t reg_index) const;

----------------
I have changed this to facilitate `WriteRegister()`. Alternatively, I suppose we could reverse the loop to match `ReadRegister()`.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89874/new/

https://reviews.llvm.org/D89874