[Lldb-commits] [PATCH] D89807: Fix "Unknown arguments specified" to if in lldb

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

In D89807#2342351 <https://reviews.llvm.org/D89807#2342351>, @ctetreau wrote:

> The real issue though is that `uppercase_CMAKE_BUILD_TYPE` is not defined at this point. I could define it, but the case of the possible values of `CMAKE_BUILD_TYPE` are well defined so there's no reason to.

I thought it was CMake that provided `uppercase_CMAKE_BUILD_TYPE` but it's llvm itself. I'm not sure how we end up here without that variable set, wiht in-tree builds we inherit all the LLVM variables and in standalone builds `AddLLVM` should take care of it. Given that the rest of LLVM uses the uppercase variant and thus accepts values like "DEBUG" I'm not a fan of being more strict here if only for the sake of consistency.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89807/new/

https://reviews.llvm.org/D89807