[Lldb-commits] [PATCH] D89408: [trace] rename ThreadIntelPT to TraceThread

[walter erquinigo via Phabricator via lldb-commits]

wallace marked 4 inline comments as done.
wallace added inline comments.


================
Comment at: lldb/source/Target/TraceProcess.cpp:40
+bool TraceProcess::CanDebug(TargetSP target_sp, bool plugin_specified_by_name) {
   return plugin_specified_by_name;
 }
----------------
labath wrote:
> Maybe this should be just `false`? I don't think we'd ever want to create this object in response to a normal "launch" request...
This has to be plugin_specified_by_name, which means that this process plug-in is only used if explicitly invoked by plugin-name. A normal "launch" request would have plugin_specified_by_name as false


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89408/new/

https://reviews.llvm.org/D89408