[Lldb-commits] [lldb] ea3a547 - [lldb] Remove bogus ProcessMonitor forward-decls

[Ed Maste via lldb-commits]

On Wed, 14 Oct 2020 at 10:44, Pavel Labath via lldb-commits
<lldb-commits at lists.llvm.org> wrote:
>
> Author: Pavel Labath
> Date: 2020-10-14T16:43:45+02:00
> New Revision: ea3a547f0be20d86b041778ae8e2779f2031f714
>
> URL: https://github.com/llvm/llvm-project/commit/ea3a547f0be20d86b041778ae8e2779f2031f714
> DIFF: https://github.com/llvm/llvm-project/commit/ea3a547f0be20d86b041778ae8e2779f2031f714.diff
>
> LOG: [lldb] Remove bogus ProcessMonitor forward-decls
>
> This class is not used in those files.
...
> diff  --git a/lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_mips64.h b/lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_mips64.h
> index 1843a2a6aff3..b66dc3f44524 100644
> --- a/lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_mips64.h
> +++ b/lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_mips64.h
> @@ -14,10 +14,6 @@
>  #include "lldb/Target/RegisterContext.h"
>  #include "lldb/Utility/Log.h"
>
> -using namespace lldb_private;
> -
> -class ProcessMonitor;
> -

The build failed with:

In file included from
/tmp/cirrus-ci-build/lldb/source/Plugins/Process/FreeBSD/FreeBSDThread.cpp:30:
/tmp/cirrus-ci-build/lldb/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_mips64.h:76:16:
error: use of undeclared identifier 'k_num_gpr_registers_mips64'; did
you mean 'lldb_private::k_num_gpr_registers_mips64'?
m_gpr_mips64[k_num_gpr_registers_mips64]; // general purpose registers.
^~~~~~~~~~~~~~~~~~~~~~~~~~
lldb_private::k_num_gpr_registers_mips64
/tmp/cirrus-ci-build/lldb/source/./Plugins/Process/Utility/lldb-mips-freebsd-register-enums.h:62:3:
note: 'lldb_private::k_num_gpr_registers_mips64' declared here
k_num_gpr_registers_mips64 = k_last_gpr_mips64 - k_first_gpr_mips64 + 1
^
1 error generated.