[Lldb-commits] [lldb] a1ab2b7 - [lldb] More memory allocation test fixes

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 14 11:43:58 PDT 2020


Author: Pavel Labath
Date: 2020-10-14T20:43:47+02:00
New Revision: a1ab2b773b6d78ec71edfebd2474c403cbe77977

URL: https://github.com/llvm/llvm-project/commit/a1ab2b773b6d78ec71edfebd2474c403cbe77977
DIFF: https://github.com/llvm/llvm-project/commit/a1ab2b773b6d78ec71edfebd2474c403cbe77977.diff

LOG: [lldb] More memory allocation test fixes

XFAIL nodefaultlib.cpp on darwin - the test does not pass there

XFAIL TestGdbRemoteMemoryAllocation on windows - memory is allocated
with incorrect permissions

Added: 
    

Modified: 
    lldb/test/API/tools/lldb-server/memory-allocation/TestGdbRemoteMemoryAllocation.py
    lldb/test/Shell/Expr/nodefaultlib.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/tools/lldb-server/memory-allocation/TestGdbRemoteMemoryAllocation.py b/lldb/test/API/tools/lldb-server/memory-allocation/TestGdbRemoteMemoryAllocation.py
index 5c8e4621ce3b..954eb23f05af 100644
--- a/lldb/test/API/tools/lldb-server/memory-allocation/TestGdbRemoteMemoryAllocation.py
+++ b/lldb/test/API/tools/lldb-server/memory-allocation/TestGdbRemoteMemoryAllocation.py
@@ -46,6 +46,7 @@ def allocate(self, size, permissions):
 
     @skipIf(oslist=no_match(supported_oses))
     @skipIf(oslist=["linux"], archs=no_match(supported_linux_archs))
+    @expectedFailureAll(oslist=["windows"]) # Memory allocated with incorrect permissions
     @llgs_test
     def test_supported(self):
         """Make sure (de)allocation works on platforms where it's supposed to
@@ -61,6 +62,7 @@ def test_supported(self):
         self.allocate(0x1100, "rwx")
 
     @skipIf(oslist=["linux"], archs=supported_linux_archs)
+    @skipIf(oslist=supported_oses)
     @llgs_test
     def test_unsupported(self):
         """Make sure we get an "unsupported" error on platforms where the

diff  --git a/lldb/test/Shell/Expr/nodefaultlib.cpp b/lldb/test/Shell/Expr/nodefaultlib.cpp
index 1bd1b6390989..5c4f19d40efc 100644
--- a/lldb/test/Shell/Expr/nodefaultlib.cpp
+++ b/lldb/test/Shell/Expr/nodefaultlib.cpp
@@ -3,12 +3,13 @@
 
 // REQUIRES: native
 // XFAIL: system-linux && !(target-x86 || target-x86_64)
-// XFAIL: system-netbsd || system-freebsd
+// XFAIL: system-netbsd || system-freebsd || system-darwin
 
 // RUN: %build %s --nodefaultlib -o %t
 // RUN: %lldb %t -o "b main" -o run -o "p call_me(5, 6)" -o exit \
 // RUN:   | FileCheck %s
 
+// CHECK: p call_me(5, 6)
 // CHECK: (int) $0 = 30
 
 int call_me(int x, long y) { return x * y; }


        


More information about the lldb-commits mailing list