[Lldb-commits] [PATCH] D89351: Move initialization of Variable::m_loc_is_const_data into constructor (NFC)

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:823
       scope, comp_unit.get(), ranges, &decl, location, is_external, false,
-      false);
-  var_sp->SetLocationIsConstantValueData(false);
+      false, false);
 
----------------
Can we add comments for these `bool` arguments, I have seen this done in llvm/clang and really helps readability e.g.:

```
/*artificial*/ false, /*location_is_constant_data*/ false, /*static_member*/ false);
```

Same goes for other places as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89351/new/

https://reviews.llvm.org/D89351