[Lldb-commits] [PATCH] D89157: [lldb] Report old modules from ModuleList::ReplaceEquivalent

[Joseph Tremoulet via Phabricator via lldb-commits]

JosephTremoulet added inline comments.


================
Comment at: lldb/source/Core/ModuleList.cpp:779-781
         if (module_sp->FileHasChanged()) {
           if (old_modules)
             old_modules->push_back(module_sp);
----------------
JosephTremoulet wrote:
> > If I run lldb on a binary, hit a breakpoint, run to it, then change a file, rebuild the executable outside lldb and rerun, I only see one instance of the executable.  Why does that path not need your fix?
> 
> The codepath where I'm inserting this comment (ModuleList.cpp lines 779-781/784-786) is the one that handles that when I run those steps under the debugger.
(see also D89156 which this change depends on)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89157/new/

https://reviews.llvm.org/D89157