[Lldb-commits] [PATCH] D89295: [lldb] Add /Users/jonas to Python's sys.path

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

In D89295#2327767 <https://reviews.llvm.org/D89295#2327767>, @teemperor wrote:

> In D89295#2327751 <https://reviews.llvm.org/D89295#2327751>, @kastiglione wrote:
>
>> For lldbinit files, and any file that gets `command source`'d, I think it would be useful if they could perform `command script import some/path/to/command.py`, where `some` is resolved relative to the dirname of the lldb file. For example, given an lldbinit file at `my/project/scripts/project.lldb`, it could load a python at `my/project/scripts/commands/my.py` by running `command script import commands/my.py`.
>
> +1, I think that would be useful. Not sure about the right way to implement this though (and whether we should make this implicit a relative path vs for example some kind of placeholder 'variable' or something like that).

That would be kind of useful, but the thing which worries me about that is the sys.path packing it will cause. I don't think that sys.path modification should be taken lightly, as every new entry there creates an opportunity for creating ambiguous imports (being able to import one file through several paths). And a lot of "interesting" things can happen when a python module gets imported through multiple paths. I think it's bad enough that every "command script import" adds a new sys.path entry. I wouldn't want "command source" to do the same...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89295/new/

https://reviews.llvm.org/D89295