[Lldb-commits] [lldb] 6733b25 - [lldb][cmake] Remove custom logic for finding VCS file to fix LLDB's VCSVersion.inc generation

Raphael Isemann via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 13 08:15:02 PDT 2020


Author: Raphael Isemann
Date: 2020-10-13T17:14:43+02:00
New Revision: 6733b2544794f2703f19f07aa7c6806408e36160

URL: https://github.com/llvm/llvm-project/commit/6733b2544794f2703f19f07aa7c6806408e36160
DIFF: https://github.com/llvm/llvm-project/commit/6733b2544794f2703f19f07aa7c6806408e36160.diff

LOG: [lldb][cmake] Remove custom logic for finding VCS file to fix LLDB's VCSVersion.inc generation

We are still implementing our own logic for this that looks for a VCS file in
the place where it was before the monorepo migration. This removes this logic
and just uses the CMake function that LLVM/Clang are using.

Reviewed By: JDevlieghere, kastiglione

Differential Revision: https://reviews.llvm.org/D88950

Added: 
    

Modified: 
    lldb/source/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/lldb/source/CMakeLists.txt b/lldb/source/CMakeLists.txt
index b196147e68e7..6dbdec5ec008 100644
--- a/lldb/source/CMakeLists.txt
+++ b/lldb/source/CMakeLists.txt
@@ -4,16 +4,8 @@ set(lldbBase_SOURCES
     lldb.cpp
   )
 
-foreach(file
-        "${LLDB_SOURCE_DIR}/.git/logs/HEAD" # Git
-        "${LLDB_SOURCE_DIR}/.svn/wc.db"     # SVN 1.7
-        "${LLDB_SOURCE_DIR}/.svn/entries"   # SVN 1.6
-        )
-  if(EXISTS "${file}")
-    set(lldb_vc "${file}")
-    break()
-  endif()
-endforeach()
+
+find_first_existing_vc_file("${LLDB_SOURCE_DIR}" lldb_vc)
 
 set(version_inc "${CMAKE_CURRENT_BINARY_DIR}/VCSVersion.inc")
 set(generate_vcs_version_script "${LLVM_CMAKE_PATH}/GenerateVersionFromVCS.cmake")


        


More information about the lldb-commits mailing list