[Lldb-commits] [PATCH] D89227: [lldb] Note difference in vFile:pread/pwrite format for lldb

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda added a comment.

Thanks for adding the clarifying text, I wrote the doc based on the existing lldb-server implementation of these packets while I was writing a separate implementation of the platform packets, so I hadn't seen the gdb docs.

Given how often the '0x' prefix on base16 numbers is dropped in the remote serial protocol, it makes me a little nervous to have a divergence here.  I think we should switch lldb / lldb-server to sending base 16 with the 0x prefix to make it clear what base it is.  Even if us sending base 10 works with lldb-server/gdbserver/my platform impl, someone may write another platform implementation that doesn't use stroul and we could have an incompatibility.

What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89227/new/

https://reviews.llvm.org/D89227