[Lldb-commits] [PATCH] D88796: [lldb] Initial version of FreeBSD remote process plugin

[Kamil Rytarowski via Phabricator via lldb-commits]

krytarowski added inline comments.


================
Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.cpp:22
+
+//#include "Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD.h"
+#include "Plugins/Process/POSIX/ProcessPOSIXLog.h"
----------------
mgorny wrote:
> krytarowski wrote:
> > Why this line?
> Because otherwise it fails to compile? ;-)
OK, you have removed the unused include.


================
Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.cpp:487
+  int count, i;
+  vm = kinfo_getvmmap(GetID(), &count);
+  if (vm == NULL) {
----------------
mgorny wrote:
> krytarowski wrote:
> > Maybe here and in other places: `struct kinfo_vmentry *vm =  kinfo_getvmmap(GetID(), &count);`
> You've mentioned previously that you'd prefer for us not to use `-lutil`. Should I inline the sysctls instead?
Yes, please.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88796/new/

https://reviews.llvm.org/D88796