[Lldb-commits] [PATCH] D88583: [lldb] [test/Register] Add read/write tests for x87 regs

Sat Oct 3 23:22:29 PDT 2020

JDevlieghere added a comment.

In D88583#2310556 <https://reviews.llvm.org/D88583#2310556>, @mgorny wrote:

> In D88583#2310538 <https://reviews.llvm.org/D88583#2310538>, @JDevlieghere wrote:
>
>> This is failing on GreenDragon so I've XFAILed the tests (temporarily). Can you take a look and see if they can be fixed and re-enabled?
>
> I'm afraid I don't have enough context. Would you be able to rerun them for me with `FILECHECK_DUMP_INPUT_ON_FAILURE=1` envvar? Also, I'd suggest adding this to buildbot — it's really helpful if something starts failing.

I think it recently became the default? Either way the bot has the input:

http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/24066/testReport/junit/lldb-shell/Register/x86_64_fp_write_test/
http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/24066/testReport/junit/lldb-shell/Register/x86_fp_read_test/

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88583/new/

https://reviews.llvm.org/D88583