[Lldb-commits] [PATCH] D88682: [lldb] [Process/NetBSD] Fix crash on unsupported i386 regs
Michał Górny via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Oct 2 00:58:59 PDT 2020
mgorny added a comment.
In D88682#2307911 <https://reviews.llvm.org/D88682#2307911>, @labath wrote:
> It sounds like the assertion could be useful (to detect the missing translations). Under what circumstances can an unknown register make its way to this function? How did you run into this code in the first place?
Very good question. I've ran into it because it crashed under me. But now I see that x86 variant of `NativeRegisterContextNetBSD_x86_64::GetSetForNativeRegNum()` doesn't handle mpx*, so they fall into wrong regsets. I suppose I should change the conditions to check both lower and upper bound of each group. Thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88682/new/
https://reviews.llvm.org/D88682
More information about the lldb-commits
mailing list