[Lldb-commits] [PATCH] D86670: [intel-pt] Add a basic implementation of the dump command

[walter erquinigo via Phabricator via lldb-commits]

wallace marked 21 inline comments as done.
wallace added inline comments.


================
Comment at: lldb/include/lldb/Target/Target.h:32
 #include "lldb/Target/ThreadSpec.h"
+#include "lldb/Target/Trace.h"
 #include "lldb/Utility/ArchSpec.h"
----------------
clayborg wrote:
> You don't need this as the only "Trace" in this file is the "TraceSP" which is a forward declaration. You will need to add it to the Target.cpp file though.
It's needed for accessing TraceDumpOptions


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86670/new/

https://reviews.llvm.org/D86670