[Lldb-commits] [PATCH] D88583: [lldb] [test/Register] Add read/write tests for x87 regs

[Michał Górny via Phabricator via lldb-commits]

mgorny updated this revision to Diff 295500.
mgorny retitled this revision from "[lldb] [test/Register] Add partial read/write tests for x87 regs" to "[lldb] [test/Register] Add read/write tests for x87 regs".
mgorny edited the summary of this revision.
mgorny added a comment.

Done as requested + improved the tests:

- switch to `FDIV` on memory operand, to be able to test FDP
- added disassembly-based test for FIP and print-based test for FDP (assuming Linux behavior for fiseg/fioff/foseg/fooff, this certainly breaks NetBSD and might break some more platforms)
- figured out how to make write test work while restoring exception state
- added FXSAVE-based check whether writing other registers works (this also includes potential future support for MXCSR)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88583/new/

https://reviews.llvm.org/D88583

Files:
  lldb/test/Shell/Register/Inputs/x86-fp-read.cpp
  lldb/test/Shell/Register/Inputs/x86-fp-write.cpp
  lldb/test/Shell/Register/x86-fp-read.test
  lldb/test/Shell/Register/x86-fp-write.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88583.295500.patch
Type: text/x-patch
Size: 6747 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20201001/5abe74f8/attachment-0001.bin>