[Lldb-commits] [PATCH] D88266: Check that the "StructuredData Plugin weak pointer" is good before trying to turn it into a shared pointer

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Sep 30 06:02:58 PDT 2020


labath added a comment.

In D88266#2302245 <https://reviews.llvm.org/D88266#2302245>, @jingham wrote:

> Use std::weak_ptr::lock to make the shared pointer, rather than std::shared_ptr::shared_ptr(std::weak_ptr) (sort of), as the latter throws.

Yep, `wp.lock()` behaves differently from the shared_ptr constructor. :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88266/new/

https://reviews.llvm.org/D88266



More information about the lldb-commits mailing list