[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

[Med Ismail Bennani via Phabricator via lldb-commits]

mib added a comment.

Spotted some little things here and there ... This patch lacks a test and would need some reformatting (`git clang-format HEAD~`) but other than that, looks ok to me.



================
Comment at: lldb/include/lldb/Symbol/Type.h:118
+    /*
+     GetModule may return module for compile uint's object file.
+     GetExeModule returns module for executable object file that contains
----------------
Typo


================
Comment at: lldb/source/API/SBType.cpp:504
+    if (!IsValid())
+        return sb_module;
+    
----------------
It would be nice to record the return value for the reproducers.


================
Comment at: lldb/source/API/SBType.cpp:507
+    sb_module.SetSP(m_opaque_sp->GetModule());
+    return sb_module;
+}
----------------
Same here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88483/new/

https://reviews.llvm.org/D88483