[Lldb-commits] [PATCH] D80659: [lldb-vscode] Redirect stderr and stdout to DAPs console message

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Sep 29 04:02:33 PDT 2020


labath added a comment.

Sorry, I confused this with the patch that was wrapping stderr into DAP messages.

Having python output break the protocol is definitely not good. Fixing it would be nice, but the solution should work on windows as well.

One possibility I'd consider is making this fix at the python level (as this is a python problem). We already are trying to do some stdin/out/err redirection there, but it seems it's not good enough. It seems it should be easy enough (though hacky, but all of this is going to be hacky anyway) to replace `sys.stdin/out/err` with a custom wrapper object.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80659/new/

https://reviews.llvm.org/D80659



More information about the lldb-commits mailing list