[Lldb-commits] [PATCH] D88266: Check that the "StructuredData Plugin weak pointer" is good before trying to turn it into a shared pointer

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Sep 28 14:09:51 PDT 2020


clayborg added a comment.

In D88266#2299110 <https://reviews.llvm.org/D88266#2299110>, @jingham wrote:

> Jonas just revived the long Doc that Todd wrote about the Structured Data printing plugins.  Seems like that is a useful thing, so I'm not in favor of getting rid of it just yet.
>
> Seems the right thing to do is if the plugin doesn't exist, call Dump straight-away.  I'll adjust the patch to do that as well.

Sounds good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88266/new/

https://reviews.llvm.org/D88266



More information about the lldb-commits mailing list