[Lldb-commits] [lldb] 6e54918 - Once we've found a firmware binary and loaded it, don't search more

[Jason Molenda via lldb-commits]

Author: Jason Molenda
Date: 2020-09-28T12:51:23-07:00
New Revision: 6e54918db7f4dad0d5a6fbff140009ed6f151d2c

URL: https://github.com/llvm/llvm-project/commit/6e54918db7f4dad0d5a6fbff140009ed6f151d2c
DIFF: https://github.com/llvm/llvm-project/commit/6e54918db7f4dad0d5a6fbff140009ed6f151d2c.diff

LOG: Once we've found a firmware binary and loaded it, don't search more

Add the flag in ProcessMachCore::DoLoadCore that stops additional
searches for the binaries when we have an LC_NOTE identifying the
firmware/standalone binary as the correct one & we have loaded it
successfully.

Added: 
    

Modified: 
    lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp b/lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp
index bee161bde96b..744942115016 100644
--- a/lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp
+++ b/lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp
@@ -398,6 +398,7 @@ Status ProcessMachCore::DoLoadCore() {
           added_module.Append(module_sp, false);
           GetTarget().ModulesDidLoad(added_module);
           m_dyld_plugin_name = DynamicLoaderDarwinKernel::GetPluginNameStatic();
+          found_main_binary_definitively = true;
         }
       }
     }