[Lldb-commits] [PATCH] D88387: Create "skinny corefiles" for Mach-O with process save-core / reading

[Med Ismail Bennani via Phabricator via lldb-commits]

mib added inline comments.


================
Comment at: lldb/include/lldb/Symbol/ObjectFile.h:700
+  /// \return
+  ///     A vector of UUIDs of binaries that were currnetly executing
+  ///     is returned; an empty vector if this information was
----------------
Little typo here.


================
Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:6863-6868
+  // struct executing_uuids {
+  //   uint32_t  version;          // version is 1
+  //   uint32_t  uuid_count;       // number of UUIDs
+  //   uuid_t    uuid[];           // array of uuid_t', uuid_count of them
+  //                               // uuid_t is 16 bytes in a Mach-O file.
+  // };
----------------
I guess you probably forgot to remove this comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88387/new/

https://reviews.llvm.org/D88387