[Lldb-commits] [PATCH] D88375: Fix MIPS and MIPS64 ABI to use ConstString in thier register info arrays.
Raphael Isemann via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Sun Sep 27 03:14:16 PDT 2020
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
To clarify the description a bit: `RegInfoBasedABI::GetRegisterInfoByName` is comparing the name/alt_name by doing a `const char *` pointer value comparison. That only works if both strings that are compared are coming from a ConstString. Since b0060c3a7868ef026d95d0cf8a076791ef74f474 <https://reviews.llvm.org/rGb0060c3a7868ef026d95d0cf8a076791ef74f474> `GetRegisterInfoByName` is checking with an assert that both C strings came from a ConstString (which is failing as these ABI implementation changed here are lacking the ConstString'ification code).
Obviously copying this code around isn't ideal, so this patch is just to get the backend at least running again until I get around to refactor this code.
Anyway, this LGTM.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits