[Lldb-commits] [PATCH] D88249: [lldb] Make protected ctor and method of SBAddress take a const reference instead of a pointer.

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Sep 24 10:49:26 PDT 2020


JDevlieghere created this revision.
JDevlieghere added reviewers: labath, werat.
JDevlieghere requested review of this revision.

Every call to the protected SBAddress constructor takes the address of a valid object which means we might as well pass it as a const reference instead of a pointer and drop the null check.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D88249

Files:
  lldb/include/lldb/API/SBAddress.h
  lldb/source/API/SBAddress.cpp
  lldb/source/API/SBBreakpointLocation.cpp
  lldb/source/API/SBFrame.cpp
  lldb/source/API/SBFunction.cpp
  lldb/source/API/SBInstruction.cpp
  lldb/source/API/SBLineEntry.cpp
  lldb/source/API/SBQueueItem.cpp
  lldb/source/API/SBSymbol.cpp
  lldb/source/API/SBValue.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88249.294113.patch
Type: text/x-patch
Size: 6768 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200924/49fc93be/attachment.bin>


More information about the lldb-commits mailing list