[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI
Jonas Devlieghere via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Sep 22 08:59:57 PDT 2020
JDevlieghere added a comment.
In D62732#2254440 <https://reviews.llvm.org/D62732#2254440>, @luismarques wrote:
> @labath @jrtc27 @clayborg Now that we have at least 3 open-source debug servers that we can use to test this with (OpenOCD, QEMU gdbstub, gdbserver) perhaps this can be merged? I had very good results using this patch with OpenOCD. This patch doesn't include automated tests, but I'm not sure what tests would be required for this patch, or that it makes sense to require them at this point. I'll be doing more work for LLDB RISC-V support, and I'll provide tests for specific fixes going forward.
Sounds reasonable to me. Maybe it's still to early for that but have you tried running (part of) the test suite under QEMU yet? It should give you a pretty good idea of the state of things and gives you a bunch of test coverage for free. You'll probably want to consider setting up a bot for that down the road anyway.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits