[Lldb-commits] [lldb] 783dc7d - [lldb] Skip TestMiniDumpUUID with reproducers

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Tue Sep 22 11:28:48 PDT 2020


Author: Jonas Devlieghere
Date: 2020-09-22T11:28:39-07:00
New Revision: 783dc7dc7ed7487d0782c2feb8854df949b98e69

URL: https://github.com/llvm/llvm-project/commit/783dc7dc7ed7487d0782c2feb8854df949b98e69
DIFF: https://github.com/llvm/llvm-project/commit/783dc7dc7ed7487d0782c2feb8854df949b98e69.diff

LOG: [lldb] Skip TestMiniDumpUUID with reproducers

The modules not getting orphaned is wreaking havoc when the UUIDs match
between tests.

Added: 
    

Modified: 
    lldb/test/API/functionalities/postmortem/minidump-new/TestMiniDumpUUID.py

Removed: 
    


################################################################################
diff  --git a/lldb/test/API/functionalities/postmortem/minidump-new/TestMiniDumpUUID.py b/lldb/test/API/functionalities/postmortem/minidump-new/TestMiniDumpUUID.py
index c4dcddba631b..052fcaebfdd0 100644
--- a/lldb/test/API/functionalities/postmortem/minidump-new/TestMiniDumpUUID.py
+++ b/lldb/test/API/functionalities/postmortem/minidump-new/TestMiniDumpUUID.py
@@ -12,6 +12,7 @@
 from lldbsuite.test import lldbutil
 
 
+ at skipIfReproducer # Modules are not orphaned and it finds the module with the same UUID from test_partial_uuid_match.
 class MiniDumpUUIDTestCase(TestBase):
 
     mydir = TestBase.compute_mydir(__file__)
@@ -213,6 +214,7 @@ def test_breakpad_overflow_hash_match(self):
         cmd = 'settings set target.exec-search-paths "%s"' % (os.path.dirname(so_path))
         self.dbg.HandleCommand(cmd)
         modules = self.get_minidump_modules("linux-arm-breakpad-uuid-match.yaml")
+        import pdb; pdb.set_trace()
         self.assertEqual(1, len(modules))
         # LLDB makes up it own UUID as well when there is no build ID so we
         # will check that this matches.
@@ -315,7 +317,6 @@ def test_add_module_build_id_4(self):
                 "a", "", "01020304-0506-0708-090A-0B0C0D0E0F10").IsValid())
         self.assertFalse(self.target.AddModule("a", "", "01020305").IsValid())
 
-    @skipIfReproducer # Modules are not orphaned and it finds the module with the same UUID from test_partial_uuid_match.
     def test_remove_placeholder_add_real_module(self):
         """
             Test that removing a placeholder module and adding back the real


        


More information about the lldb-commits mailing list