[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

[António Afonso via Phabricator via lldb-commits]

aadsm added a comment.



> It seems like calling any 'mmap' definition should work. Is the interposed mmap implementation failing and correctly returning -1, or is it succeeding and incorrectly returning -1? In either case, it seems like it's worth digging into why it's failing / returning the wrong result

@vsk, yeah, this is what I've tried to do before I submitted this diff. It should work because it works when lldb is not attached. I wanted to step into it (by defining SINGLE_STEP_EXPRESSIONS) and see what's going on but the process crashes on me when I do that. It has to work just because if I call `__interceptor_mmap` it works and the only difference between those two is that one calls `internal_iserror`. InferiorCallMmap uses ThreadPlanCallFunction which seems to ignore breakpoints because it uses the subplan "run to address" that makes sure it only stops at the address given so it has been hard to put a breakpoint there. The only exception to this is when I define the SINGLE_STEP_EXPRESSIONS but like I said the process crashes or something, don't remember anymore. I can try again.

@clayborg I'll try that.

Thanks everyone for their input, I'll follow up on this next week because right now I'm on vacation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87868/new/

https://reviews.llvm.org/D87868