[Lldb-commits] [PATCH] D85705: Add a "Trace" plug-in to LLDB to add process trace support in stages.

[walter erquinigo via Phabricator via lldb-commits]

wallace marked an inline comment as done.
wallace added inline comments.


================
Comment at: lldb/source/Target/TraceSettingsParser.cpp:128
+    std::string plugin_schema(GetPluginSchema());
+    plugin_schema = std::regex_replace(plugin_schema, std::regex("\n"), "\n  ");
+    schema_builder << plugin_schema << ",\n";
----------------
MaskRay wrote:
> The replacement here looks strange.
> 
> `<regex>` implementations tend to be large, slow and buggy. It'd be best if <regex> can be avoided. (llvm has llvm/Support/Regex.h)
will do!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85705/new/

https://reviews.llvm.org/D85705