[Lldb-commits] [PATCH] D87878: [DWARFYAML] Make the include_directories, file_names and opcodes fields of the line table optional.
Xing GUO via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Sep 18 01:30:42 PDT 2020
Higuoxing updated this revision to Diff 292719.
Higuoxing added a comment.
In D87878#2281189 <https://reviews.llvm.org/D87878#2281189>, @jhenderson wrote:
> I might be missing it, but do you have direct testing showing that the default for `IncludeDirs`\`Files`\`Opcodes` is an empty output, when the output is written? I think it's important that this is tested.
Sorry, I didn't test it.
Add test case (k) in llvm/test/tools/yaml2obj/ELF/DWARF/debug-line.yaml.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87878/new/
https://reviews.llvm.org/D87878
Files:
lldb/unittests/Symbol/Inputs/inlined-functions.yaml
llvm/lib/ObjectYAML/DWARFYAML.cpp
llvm/test/ObjectYAML/MachO/DWARF-debug_info.yaml
llvm/test/ObjectYAML/MachO/DWARF-debug_line.yaml
llvm/test/ObjectYAML/MachO/DWARF5-debug_info.yaml
llvm/test/tools/llvm-dwarfdump/X86/verify_attr_file_indexes.yaml
llvm/test/tools/llvm-dwarfdump/X86/verify_attr_file_indexes_no_files.yaml
llvm/test/tools/llvm-gsymutil/ARM_AArch64/fat-macho-dwarf.yaml
llvm/test/tools/llvm-gsymutil/X86/mach-dwarf.yaml
llvm/test/tools/llvm-objcopy/MachO/Inputs/strip-all-with-dwarf.yaml
llvm/test/tools/yaml2obj/ELF/DWARF/debug-line.yaml
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D87878.292719.patch
Type: text/x-patch
Size: 9742 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20200918/b6012984/attachment.bin>
More information about the lldb-commits
mailing list