[Lldb-commits] [PATCH] D87765: [llvm][lldb] Add optimal ThreadPool concurrency

Alexandre Ganea via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Sep 17 05:33:36 PDT 2020


aganea accepted this revision.
aganea added a comment.
This revision is now accepted and ready to land.

Side-note: @dmantipov Could you please use `git diff -U99999` when creating patches? This allows reviewers to quickly browse through other parts of the file(s) in Phabricator. That would fix the "Context not available." message.

The patch looks like a quick win on the short term. A better fix would create threads on-the-go as work is being pushed on the queue. An even better fix would be a system-wide thread pool for all LLVM apps. But that would require more effort, especially on testing & maintenance.

LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87765/new/

https://reviews.llvm.org/D87765



More information about the lldb-commits mailing list