[Lldb-commits] [PATCH] D86660: Modifying ImportDeclContext(...) to ensure that we also handle the case when the FieldDecl is an ArrayType whose ElementType is a RecordDecl
Gabor Marton via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Sep 17 00:10:19 PDT 2020
martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.
In D86660#2278025 <https://reviews.llvm.org/D86660#2278025>, @shafik wrote:
> We are going to move forward with this approach (after dealing with the multi-dimensional array case) temporarily. We are seeing crash bugs from this from users and we want to fix it while we explore the solution space more.
Okay, I understand the business reasons and I am fine with this patch if this is really a temporary solution. Just please add a FIXME that indicates this and D71378 <https://reviews.llvm.org/D71378> are temporary, plus that this should be really handled by the preceding `import` call.
CHANGES SINCE LAST ACTION
More information about the lldb-commits